feat: battle reward/#688#689
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a reward system for battle completion and attendance marking, including the addition of reward history tracking. Key changes include updating BattleFinishService to grant cookies based on battle duration and result, and modifying MarkAttendanceService to record attendance rewards. The review feedback identifies critical race conditions in the reward granting logic where user balances are updated without database locks, which could lead to lost updates in concurrent environments. Additionally, there is a suggestion to improve the readability and consistency of the draw reward calculation.
redjungi09
approved these changes
Apr 15, 2026
Finefinee
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
UserGoodsHistory기록 저장GoodsActingCategory에BATTLE_WIN_REWARD,BATTLE_LOSE_REWARD,BATTLE_DRAW_REWARD,ATTENDANCE_DAILY_REWARD,ATTENDANCE_WEEKLY_REWARD추가관련 이슈
Closes #688
추가 컨텍스트
finishExpiredBattles)와 lazy 단건 처리(finishSingleIfExpired) 양쪽 모두에 적용됨